Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix id and class definition #3202

Merged
merged 1 commit into from
Jan 15, 2018
Merged

fix id and class definition #3202

merged 1 commit into from
Jan 15, 2018

Conversation

DanielRuf
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

This should add the right class and id definitions as they are currently missing.

Benefits

Right image dimensions.

Applicable issues

Docs

@jsf-clabot
Copy link

jsf-clabot commented Jan 14, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.018% when pulling 7571c79 on DanielRuf:fix-docs-attributes into c7730a6 on mochajs:master.

boneskull
boneskull suggested changes Jan 15, 2018
View reviewed changes
Copy link
Contributor

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I can't see any difference between mochajs.org and the preview. The image-list class still seems to be missing...

@DanielRuf
Copy link
Contributor Author

Thanks. I can't see any difference between mochajs.org and the preview. The image-list class still seems to be missing...

Mh, what is the needed markdown / kramdown markup here? I do not have make and would need a setup for Windows for further testing.

@DanielRuf
Copy link
Contributor Author

Information on the needed code is quite rare =/

@DanielRuf
Copy link
Contributor Author

I guess I fixed it.
Kramdown should be after the actual block / element / code.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.018% when pulling bdd3c4f on DanielRuf:fix-docs-attributes into 0a3e32b on mochajs:master.

@DanielRuf
Copy link
Contributor Author

Currently testing the ID which is still missing.

@DanielRuf
Copy link
Contributor Author

Seems to be fixed now. https://deploy-preview-3202--mocha.netlify.com/

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.018% when pulling 64d4d43 on DanielRuf:fix-docs-attributes into 0a3e32b on mochajs:master.

@Munter
Copy link
Contributor

Munter commented Jan 15, 2018

Nice catch. Thank you for the contribution.

Next time I need to do anything like that I'll just go pure HTML. At least I know what I'm doing there :D

@Munter Munter merged commit 7d8abe0 into mochajs:master Jan 15, 2018
@DanielRuf DanielRuf deleted the fix-docs-attributes branch January 15, 2018 21:52
@boneskull boneskull added this to the v5.0.0 milestone Jan 17, 2018
@boneskull boneskull added area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jan 17, 2018
@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
This was referenced Sep 22, 2018
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Sep 23, 2018
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Oct 2, 2018
Closed
Closed
Closed
Open
This was referenced Oct 28, 2018
Merged
Closed
Closed
Merged
This was referenced Nov 4, 2018
Merged
Merged
Merged
This was referenced Nov 12, 2018
Closed
Merged
Closed
@renovate renovate bot mentioned this pull request Nov 23, 2018
Merged
This was referenced Dec 1, 2018
Closed
Merged
Merged
This was referenced Dec 8, 2018
Merged
Closed
Merged
Closed
This was referenced Dec 23, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull boneskull requested changes

Assignees
No one assigned
Labels
area: browser browser-specific area: reporters involving a specific reporter semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DanielRuf @jsf-clabot @coveralls @Munter @boneskull